Add a prediff to fix .good mismatch #19322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapel-lang#19321 inadvertently enabled the testing of: test/deprecated/RegexpModule.chpl test/deprecated/regexp-rechan.chpl test/deprecated/regexp_error.chpl in the default configuration (and many others). While they were not being tested, however, a difference in line numbers in modules/standard/IO.chpl has crept in for `regexp-rechan.chpl` . This PR adds a .prediff to eliminate sensitivity of this test to such line numbers. Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
dlongnecke-cray
approved these changes
Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19321 inadvertently enabled the testing of:
in the default configuration (and many others).
While they were not being tested, however, a difference in line numbers
in modules/standard/IO.chpl has crept in for
regexp-rechan.chplso it started to fail.
This PR adds a .prediff to eliminate sensitivity of this test
to such line numbers so now it passes.