Hide internal module names used by ChapelStandard #19788
Conversation
--- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
|
@mppf: See what you think. |
|
I think an interesting next step would be to make these internal modules all into submodules of ChapelStandard (so you would e.g. |
|
I had a different and more aggressive next step in mind: Simply not make the internal module names ever be visible to user code so that we'd avoid conflicts and even avoid letting the user refer to them. Note that even ChapelStandard is a name that isn't really intended to be user facing (and if it were, I'd probably call it something else anyway). |
|
Proposed the idea in #19793. |
--- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
bradcray
changed the title
This test is only run on linux32, so escaped my testing and refers to an internal module, which is no longer available by default. Here, I'm using an explicit `use` to bring the module's name into scope, though this will also break if/when we implement the proposal in --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
…le-ref Fix failing test fallout from #19788 [trivial, not reviewed] This test is only run on linux32, so escaped my testing and refers to an internal module, which is no longer available by default. Here, I'm using an explicit `use` to bring the module's name into scope, though this will also break if/when we implement the proposal in #19793.
This test is only run on linux32, so escaped my testing and refers to an internal module, which is no longer available by default. Here, I'm using an explicit `use` to bring the module's name into scope, though this will also break if/when we implement the proposal in --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
This is a follow-up to #19306 which took pains to keep internal module symbols
visible to code by default via its use of
ChapelStandard. We don't generallywant to make these internal module names known/knowable to users, so this
PR hides them again and updates the one place I found that had been relying
on them being auto-available.