Address a gcc 12 warning #19835
Merged
Address a gcc 12 warning #19835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc 12 is smart enough to realize that the second part of this conditional will only be hit iff the first part is, and warns about it (breaking a CHPL_DEVELOPER compile). So simplify the conditional by removing the second part. This code has been around for a looong time! --- Signed-off-by: Brad Chamberlain <bradcray@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gcc 12 is smart enough to realize that the second part of the
conditional that I'm modifying in this PR will be true only iff
the first part is, and warns about it (breaking a CHPL_DEVELOPER
build). So simplify the conditional by removing the second part.
This code has been around for a looong time!