Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ItemReader and ItemWriter #20351

Merged
merged 3 commits into from Aug 3, 2022

Conversation

benharsh
Copy link
Member

@benharsh benharsh commented Aug 2, 2022

ItemReader, ItemWriter, and their relevant methods on the channel type were both deprecated in #19896. This PR removes these deprecated types and methods.

Testing:

  • full linux64

Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
Signed-off-by: Ben Harshbarger <ben.harshb@gmail.com>
@lydia-duncan lydia-duncan self-requested a review August 3, 2022 21:36
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@benharsh benharsh merged commit 1c7491c into chapel-lang:main Aug 3, 2022
@benharsh benharsh deleted the remove-ItemReaderWriter branch August 7, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants