Homebrew formula: use cstdlib and fifo tasks #23415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- Signed-off-by: Andy Stone <stonea@users.noreply.github.com>
ronawho
approved these changes
Sep 15, 2023
|
Oh, should probably remove the depends_on hwloc/jemalloc |
--- Signed-off-by: Andy Stone <stonea@users.noreply.github.com>
Good catch; I've removed them. |
ronawho
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #23366, I updated the Homebrew formula to use system versions of jemalloc and hwloc.
Unfortunately, this change runs into issues. Some of which may be fixed later by this PR (#23409 (comment)).
And also this issue about the bundled jemalloc makefile being run and failing despite the fact that we're supposed to be using the system one #23409 (comment)).
Given all this and how close we are to the release, we decided to have the formula use cstdlib for memory management instead.