-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated range.stridable, range.boundedType, BoundedRangeType #24136
Remove deprecated range.stridable, range.boundedType, BoundedRangeType #24136
Conversation
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This PR fixes test failures introduced by #24136 and #24138. Suggested by @jabraham17. Trivial, not reviewed.
Signed-off-by: Vassily Litvinov <vasslitvinov@users.noreply.github.com>
This PR updates .good files with line numbers that changed due to #24136. Could we instead prediff-out these line numbers? Yes, by copying from one of multiple existing prediff scripts (possibly using a more specific path) that contain this: !/usr/bin/env bash # Ignore line numbers in modules. sed '\|CHPL_HOME/modules|s/:[0-9]*:/:nnnn:/' $2 > $2.tmp mv $2.tmp $2 SHOULD we prediff-out the these line numbers? Citing Engin, "this is one of those cases where it is not as clear to me: this is a memory diagnostic test, and it is kind of important to see which line numbers are producing the message." So I choose to retain the (very mild) maintenance burden of keeping the explicit line numbers in order to provide more robust testing. For a general background, we apply the above prediff conversion in 50+ .prediff and PREDIFF scripts. Furthermore we convert such line numbers automatically when comparing against .bad files, see `diff-ignoring-module-line-numbers`. We may want to make this conversion automatic for .good files as well, which I am leaving outside the scope of this PR. r: @e-kayrakli
@vasslitvinov - I think this PR should have removed this compiler code? Do you know if there is a reason it did not? chapel/frontend/lib/resolution/scope-queries.cpp Lines 2115 to 2137 in 476c51c
|
Good catch, thanks! I will look into it. |
Removed in #24996. |
These features were deprecated in 1.31 as follows:
range.
boundedType
andBoundedRangeType
issue: #17126 implementation: #22059range.
stridable
issue: #17131 implementation: #22441, #22486, #22508This PR removes support for these features, which was added in the above PRs, and adjusts modules and tests accordingly.
More range/domain deprecated feature removals are next steps.
Testing: standard and gasnet paratests; distribution robustness suite as tested nightly: block, cyclic, replicated.