Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Chapel programs with COMM=ofi to use explicit transparent huge pages #24971

Merged
merged 3 commits into from
May 6, 2024

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented May 2, 2024

This PR adds a new runtime variable, CHPL_RT_COMM_OFI_THP_HINT, which controls if the OFI comm layer will use transparent huge pages to allocate memory. The default value is false, except when the provider being used is EFA. The default is true for EFA, since EFA is severely limited in the number of pages it can register.

This PR also updates the docs for using Chapel on AWS to explain how to enable and use transparent huge pages.

This PR requires #24969 to be merged first

Tested on AWS

[Reviewed by @jhh67]

Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@jabraham17 jabraham17 requested a review from jhh67 May 2, 2024 14:16
runtime/src/comm/ofi/comm-ofi.c Outdated Show resolved Hide resolved
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@jabraham17 jabraham17 merged commit 172da27 into chapel-lang:main May 6, 2024
7 checks passed
@jabraham17 jabraham17 deleted the use-thp branch May 6, 2024 17:02
jabraham17 added a commit that referenced this pull request May 6, 2024
Adds more documentation to `doc/rst/platforms/libfabric.rst` about
`CHPL_RT_MAX_HEAP_SIZE` and `CHPL_RT_COMM_OFI_THP_HINT`

This is a follow-on to #24971
and #24967

Built and checked docs locally

[Reviewed by @jhh67]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants