Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scripts to build non-default Chapel packages #25076

Merged
merged 34 commits into from
Jun 13, 2024

Conversation

jabraham17
Copy link
Member

@jabraham17 jabraham17 commented May 20, 2024

Adds scripts to build some packages for a few other configurations. Because this would have resulted in huge amounts of duplicated code, this PR adds some templating support for the Docker builds

Configurations

  • COMM=ofi, LAUNCHER=slurm-srun
    • ubuntu22
    • el9
  • COMM=gasnet, SUBSTRATE=udp, LAUNCHER=amudprun
    • debian12
    • ubuntu22
    • el9
  • COMM=none
    • fc40
    • ubuntu24 (only works with Chapel 2.1)

Other additions:

  • Added util/packaging/rpm/common/fill_docker_template.py and util/packaging/apt/common/fill_docker_template.py which can fill in Docker.template files.
    • Refactored the existing packages to use the templating
  • Added more helpers to util/packaging/common/build_helpers.sh
  • Switch to using chplconfig

Followup to #25051

Tested that the above configs build locally with __build_image
Also tested that the existing COMM=none configs that were modified continue to build locally

  • ubuntu20
  • ubuntu22
  • fc37
  • fc38
  • fc39
  • debian11
  • debian12

Note: the OFI builds work, but since they do not link against pmi2 statically so libpmi2.so must be present on compute nodes. This is a current limitation that I consider future work

[Reviewed by @jhh67]

jabraham17 added a commit that referenced this pull request Jun 5, 2024
This PR adds a few missing parts to some of the packaging scripts used
to build OS packages.

These are currently error-prone, as there is a lot of duplicated code
between scripts. This PR serves as a stop gap measure until [this PR is
ready](#25076).

[Reviewed by @jhh67]
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@jabraham17 jabraham17 requested a review from jhh67 June 12, 2024 22:38
Signed-off-by: Jade Abraham <jade.abraham@hpe.com>
@jabraham17 jabraham17 merged commit 05ed48a into chapel-lang:main Jun 13, 2024
6 checks passed
@jabraham17 jabraham17 deleted the chapel-packages-comm branch June 13, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants