Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC 2016: Updated stack trace format #4125

Merged
merged 3 commits into from Jul 14, 2016
Merged

GSoC 2016: Updated stack trace format #4125

merged 3 commits into from Jul 14, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 5, 2016

This PR:

  • Introduces a new format for the stack trace
  • Provides a system-wide prediff for the testing system that removes the stack trace from some specific test output.

- Added system prediff for stack trace testing
@ghost
Copy link
Author

ghost commented Jul 5, 2016

As an example of the new format, this program

proc main(){
  fact(2);
}

proc fact(i : int) :int{
  if(i == 0) then halt();
  else return i*fact(i-1);
}

produces

test.chpl:6: error: halt reached
Stacktrace

halt() at $CHPL_HOME/modules/internal/ChapelIO.chpl:679
fact() at prova.chpl:5
fact() at prova.chpl:5
fact() at prova.chpl:5

@mppf mppf self-assigned this Jul 5, 2016
# text output, no newline - which ones?
( declprintint | fwriteIntFile | fwriteMultipleInts | fwriteIntStdout )
exit
esac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the logic above really necessary? Also, I'd prefer this prediff be written in Python or Perl. It would be better to read the output one line at a time and check for the Stacktrace region. As it is, I think the grepping below might mess up test output. But there's no real reason to change anything at all until we get to a region just after a line that was exclusively "Stacktrace".

@mppf mppf merged commit 7df2cc2 into chapel-lang:master Jul 14, 2016
@ghost ghost deleted the pretty-stacktrace branch July 15, 2016 14:23
@mppf mppf changed the title Updated stack trace format GSoC 2016: Updated stack trace format Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant