[GSoC] Noinline attribute when using llvm-print-ir #6280
Conversation
compiler/codegen/symbol.cpp
Outdated
| @@ -56,6 +54,10 @@ | |||
| #include <inttypes.h> | |||
| #include <stdint.h> | |||
|
|
|||
| #ifdef HAVE_LLVM | |||
| #include "llvm/IR/Attributes.h" | |||
| #endif | |||
There was a problem hiding this comment.
I don't like putting these ifdefs here, but I can't see the default place where to put these ifdefs. Any guidance would be great.
There was a problem hiding this comment.
This is OK. I'd probably put the LLVM include before the first system include (<algorithm>). compiler/include/llvmUtil.h might work too but it's probably smarter to just put the include you need for this file here. Speaking of that, I'm surprised that the other llvm:: stuff in this file worked and addFnAttr didn't. Are you sure you can't just remove the new include entirely?
There was a problem hiding this comment.
Well, apparently it does, I can recall that it didn't compile without this header but apparently my crazy mind made it up.
|
Passed full local testing.
|
coodie
changed the title
In full optimization stage function sometimes was inlined and removed from llvm module, easiest way to fix this is to add 'noinline' attribute for it.
The preferred way however is to add noinline pragma before function we want to print so that this option doesn't interfere with other optimization options and it is explicitly stated in code.
Other solution would be add llvm-print-inline option which would specify if we want to turn this off or on.
Anyway, now we can see that adding noinline attribute is very easy to do.