[GSoC] Mark const variables using llvm.invariant.start #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these fail runtime/sungeun/chpl-env-gen but that might happen on master... |
|
Passed full local testing. |
llvm.invariant.start of pointer to pointer type
… it cannot be used like that, too bad I didn't realise that I've added that to my code, it'd save me a lot of debugging
coodie
changed the title
4 tasks
mppf
added a commit
that referenced
this pull request
May 31, 2023
This PR adjusts the Chapel code generator to not generate calls to `llvm.invariant.start`. The reason for doing that is that we are seeing test failures for some tests with `--fast` after upgrading to LLVM 15. Generation of `llvm.invariant.start` was initially added in PR #6706. I'd like to fix the problems with these in a better way than just not generating `llvm.invariant.start`, but removing it for now is the short-term solution in case I cannot come up with a fix in a reasonable amount of time. Note that it is still possible to generate a call to one of these with `PRIM_INVARIANT_START` but that is not done in any modules or tests. Reviewed by @riftEmber - thanks! - [x] full comm=none --fast testing with a system LLVM 14 - [x] full comm=none --fast testing with a system LLVM 15 - [x] full comm=none testing with a system LLVM 14 - [x] full comm=none testing with a system LLVM 15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks const variables using llvm.invariant.start.
I am not 100% sure if I check for constness correctly, I have huge difficulties understanding what chapel compiler is doing, @mppf should be able to see instantly if I add this in correct spots.