[GSoC] Fix forVersusWhilePerf.chpl #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, didn't get a notification from the edit. Looking at this now! |
| @@ -29,9 +32,19 @@ proc main() { | |||
| else | |||
| res2 = res2 / 2; | |||
| j += 1; | |||
| } | |||
| } | |||
There was a problem hiding this comment.
This line adds some trailing whitespace
| @@ -43,7 +56,7 @@ proc main() { | |||
| writeln("For loop underwent ", numIterations, " iterations ", numTrials, | |||
| " times in ", t1.elapsed(TimeUnits.milliseconds)/1000, " seconds"); | |||
| writeln("While loop underwent ", numIterations, " iterations ", numTrials, | |||
| " times in ", t2.elapsed(TimeUnits.milliseconds)/1000, " seconds"); | |||
| " times in ", t2.elapsed(TimeUnits.milliseconds)/1000, " seconds"); | |||
There was a problem hiding this comment.
This changes the whitespace for the worse
|
Awesome, thanks! |
lydia-duncan
added
stat: Ready to Merge
and removed
stat: Waiting on Contributor
labels
ronawho
added a commit
to ronawho/chapel
that referenced
this pull request
Jul 29, 2017
PR chapel-lang#6833 changed forVersusWhilePerf.c to be more comparable to the Chapel version. It changed some int's to int64_t's, but used the wrong printf formatter and didn't include stdint.h. Here I include stdint.h and cast the results in printf to long ints. I could have used the PRId64 formatter, but I never remember how portable that is, and we don't use it in any other tests, so I opted to just cast in order to quiet the regression for now.
ronawho
added a commit
that referenced
this pull request
Jul 29, 2017
Quiet forVersusWhilePerf regressions PR #6833 changed forVersusWhilePerf.c to be more comparable to the Chapel version. It changed some int's to int64_t's, but used the wrong printf formatter and didn't include stdint.h. This just includes stdint.h and cast the results in printf to long ints. I could have used the PRId64 formatter, but I never remember how portable that is, and we don't use it in any other tests, so I opted to just cast in order to quiet the regression for now.
coodie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at current performance graphs one can notice that in case of LLVM chapel's version of this test there is slight performance degradation, after some investigation I realized that this test is not written well due to few factors:
After changing all "int" to "int64_t" and "static const int64_t" to "int64_t" the Chapel's version performance closely matches the C version performance.
I guess @lydia-duncan is the best person to review this PR since she wrote those tests in first place.