For now, don't mark standard module iters as throws #7135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue chapel-lang#7134 indicates that throwing iterators don't currently work unless they are inlined. That means that any iterator that is used in tests in --baseline testing can't be marked throws without causing errors in that configuration. To quiet testing, this PR simply makes the two iter functions in the standard modules that throw currently not throwing. Instead, these functions use try! to halt if any error was encountered. This is intended to be a temporary change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #7134 indicates that throwing iterators don't currently work unless they are inlined. That means that any iterator that is used in tests in --baseline testing can't be marked throws without
causing errors in that configuration.
To quiet testing, this PR simply makes the two throwing iter functions in the standard modules no longer throw. Instead, these functions use try! to halt if any error was encountered. This is
intended to be a temporary change.
Reviewed by @psahabu - thanks!