update FileSystem module to use error handling #7174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 tasks
lydia-duncan
reviewed
Sep 6, 2017
| var err: syserr = ENOERR; | ||
| chdir(err, name); | ||
| if err != ENOERR then ioerror(err, "in chdir", name); | ||
| if err != ENOERR then try ioerror(err, "in chdir", name); |
There was a problem hiding this comment.
I'm a little surprised these are trys instead of direct throws, though I'm assuming ioerror is a function that throws?
There was a problem hiding this comment.
I say that because the intention of those statements is that if we enter the then block, we are in an error situation and so it would be problematic not to throw if that's the behavior we should perform (as opposed to halting)
There was a problem hiding this comment.
Right, ioerror() is a function that throws if an err is passed to it. It was easier to change the code in ioerror once rather than replace all calls with a throw, at least for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several procedures in
FileSystemwould halt if they encountered an error, but this PR enables users to handle a SystemError if they prefer. No tests were handling syserr fromFileSystem.