Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reversed sense of vectorize enable flag #9577

Merged
merged 1 commit into from May 17, 2018
Merged

Fix reversed sense of vectorize enable flag #9577

merged 1 commit into from May 17, 2018

Conversation

dmk42
Copy link
Contributor

@dmk42 dmk42 commented May 17, 2018

In #9567 , explicit vectorization metadata was enabled when not using the Region Vectorizer, causing messages about failed vectorization to print out. This causes some tests to fail.

This happened because the metadata was enabled when not using the RV, and disabled when using the RV. I believe it was meant to be the other way around.

Here is an example of the extraneous messages.

remark: <unknown>:0:0: loop not vectorized: call instruction cannot be vectorized
remark: <unknown>:0:0: loop not vectorized: call instruction cannot be vectorized
warning: <unknown>:0:0: loop not vectorized: failed explicitly specified loop vectorization
warning: <unknown>:0:0: loop not vectorized: failed explicitly specified loop vectorization

@dmk42
Copy link
Contributor Author

dmk42 commented May 17, 2018

@mppf - Would you please do a post-commit review?

@dmk42 dmk42 merged commit b7103d1 into chapel-lang:master May 17, 2018
@mppf
Copy link
Member

mppf commented May 18, 2018

@dmk42 - thanks for the fix - I believe you are right about this

@dmk42 dmk42 deleted the fix-vec-msg branch June 22, 2018 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants