Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new keywords and : operator to the pygments lexer #47

Merged
merged 4 commits into from Mar 9, 2021
Merged

Add new keywords and : operator to the pygments lexer #47

merged 4 commits into from Mar 9, 2021

Conversation

e-kayrakli
Copy link
Contributor

The new keywords in Chapel 1.24: operator, foreach, implements, interface
We also accept : as operator, now.

While there, also adds primitive as a keyword to the lexer.

@e-kayrakli
Add new keywords and : operator to the pygments lexer
e13c9c5 
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
@e-kayrakli
Also add primitive as a keyword
eeafd1a 
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
lydia-duncan
lydia-duncan approved these changes Mar 9, 2021
View reviewed changes
Copy link
Member

@lydia-duncan lydia-duncan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I do still want to update the Sphinx domain itself to treat operators and interfaces appropriately but that's more involved than we want to get into right now

@e-kayrakli
Bump up the copyright year in the lexer
7fd403f 
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
@e-kayrakli
Make the linter happy
bbc6b9f 
Signed-off-by: Engin Kayraklioglu <e-kayrakli@users.noreply.github.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 60.465% when pulling bbc6b9f on e-kayrakli:new-keywords into 61a95ad on chapel-lang:master.

@e-kayrakli e-kayrakli merged commit b8d69d5 into chapel-lang:master Mar 9, 2021
@e-kayrakli e-kayrakli deleted the new-keywords branch March 9, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydia-duncan lydia-duncan lydia-duncan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@e-kayrakli @coveralls @lydia-duncan