Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon HTML not added to output #8

Closed
cliffhall opened this issue Aug 31, 2019 · 1 comment
Closed

Favicon HTML not added to output #8

cliffhall opened this issue Aug 31, 2019 · 1 comment

Comments

@cliffhall
Copy link
Contributor

Currently the modules/favicon.html is presumably supposed to be added to the dist/index.html when running tweegobuild. However it is not added.

After reading the tweego docs for the -m about twenty times, I finally noticed that .html is not a supported extension:

-m SRC, --module=SRC
Module sources (repeatable); may consist of supported files and/or directories to recursively search for such files. Each file will be wrapped within the appropriate markup and bundled into the element of the compiled HTML. Supported files: .css, .js, .otf, .ttf, .woff, .woff2.

To insert an HTML snippet into the head of the output file, you need to use --head:

--head=FILE
Name of the file whose contents will be appended as-is to the element of the compiled HTML.

By changing the tweegobuild script in package.json it did the right thing:

tweego -f $npm_package_config_format -m src/modules/ --head=src/modules/head.html -o dist/index.html project

Even though it seems redundant, I left the -m src/modules/ in place because if someone wants to add fonts they can do so.

@ChapelR
Copy link
Owner

ChapelR commented Aug 31, 2019

Thanks, merged.

@ChapelR ChapelR closed this as completed Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants