Added a new resolver module for Virustotal API, #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by allowing cli arguments for picking a resolver. Implemented error handling and code refactoring.
chapinb
reviewed
May 25, 2023
| } | ||
| Ok(results) | ||
| } | ||
| } |
There was a problem hiding this comment.
Let's add a tests module to this, at least for the parse method and we can figure out the best way to add tests for the VT API since it requires an API key.
| Ok(vt_record) | ||
| } | ||
|
|
||
| pub fn resolve(&self, ip_addresses: Vec<IpAddr>) -> anyhow::Result<Vec<String>> { |
There was a problem hiding this comment.
Nice work! We should drop the print statements since we want to present the output to the user within main.rs
| .filter_map(|record| serde_json::to_string(record).ok()) | ||
| .collect()) | ||
| match resolver_type.to_lowercase().as_str() { | ||
| "ip-api" | "ipapi" | "IPAPI" => { |
There was a problem hiding this comment.
good idea to handle multiple user inputs for both this and virustotal
| @@ -142,7 +147,8 @@ fn run_chickadee(ips: String, columns: Option<Vec<String>>) -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[cfg(test)] | |||
| /* | |||
| [cfg(test)] | |||
There was a problem hiding this comment.
We will need to re-enable the tests ;)
We should also add tests for the new CLI arg and resolver parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrated into main by allowing cli arguments for picking a resolver. Implemented error handling and code refactoring.
This commit solves issue #6