Address errors in reading from stdin (Sourcery refactored) #89

sourcery-ai · 2023-05-26T12:31:10Z

Pull Request #88 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the 69-parse-stdin-errors branch, then run:

git fetch origin sourcery/69-parse-stdin-errors
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai · 2023-05-26T12:31:12Z

libchickadee/chickadee.py

-        if args_val != v and args_val is not None:
+        if (
+            args_val != v
+            and args_val is not None
+            or not config_val
+            and args_val is not None
+        ):
            final_config[k] = args_val

-        # Next get from the config
        elif config_val:
            final_config[k] = config_val

-        # Otherwise load from args if present
-        elif args_val is not None:
-            final_config[k] = args_val


Function join_config_args refactored with the following changes:

Merge duplicate blocks in conditional (merge-duplicate-blocks)

Remove redundant conditional [×2] (remove-redundant-if)

This removes the following comments ( why? ):

# Next get from the config # Otherwise load from args if present