Using Redis TTL to expire keys after a certain point #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 15, 2017 14:49
…flows added expire_workflow and expire_job methods to client Right now you need to manually call expire! to set expiration for the workflow keys. Alternative design would be to leverage callback that will automatically call this after last job in workflow completes.
…nning w particular class name
|
Hey @dmitrypol! Apologies for super late reply, this looks really great! I only have some notes about the text in readme, but will adjust after merging :) And yeah, this is a good time to switch to actual Redis servers to test TTL. |
|
@dmitrypol this is now released in version 1.1.0 🥇 |
|
Thanks for merging it. Completely understand slow response, life is busy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #26 here is a first attempt at expiring workflow keys. Please consider for including this feature in the library or modify as appropriate.
I added a test for Client.expire_workflow but I think fakeredis TTL does not work quite the same as Redis (had issues w it in the past).
On separate note I updated README with suggestion on how to check whether workflow is running w particular class name. Helps avoid overlapping workflow same class.
Dmitry