New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements #53

Merged

pokonski merged 3 commits into master from performance-improvements

Feb 5, 2018

Contributor

pokonski commented Feb 5, 2018

This PR improves performance in 3 places:

uses SCAN instead of KEYS to be non-blocking
stops serializing jobs into workflow JSON (breaking change but unlikely anyone relied on this)
parents_succeeded? is no longer eagerly checking all parents and instead does inverse to look for the first non-succeeded job

pokonski added 3 commits

December 22, 2017 20:19


          Don't serialize jobs into workflow JSON, it's redundant

029b08f


          Use SCAN instead of KEYS to not lock redis completely with a single c…

71a5c38

…ommand


          Map nodes instead of pushing

3085a61

pokonski merged commit 879df7b into master

pokonski deleted the performance-improvements branch

February 5, 2018 04:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment