Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed GPL libraries in favor of MIT compatible ones #80

Merged
merged 5 commits into from Mar 10, 2022

Conversation

rmorlok
Copy link
Contributor

@rmorlok rmorlok commented Jul 30, 2020

Removed the colorize and ruby-graphviz libraries which were GPL and not compatible with the Gush MIT license. Replaced them with paint and graphviz, respectively.

Enhanced options for graph vizualization by allowing a filename to be specified to retain the output of the graph. Allowed graphs to be generated from specific workflows that exist in Redis in addition to coming straight from the class definition (for systems that may choose to make the structure of the graph dynamic based on inputs).

Standardized CLI documentation format.

anirbanmu and others added 5 commits February 18, 2020 10:00
Gush can work with ActiveJob 6, no need to limit it to < 6.0.
Removed the [colorize](https://github.com/fazibear/colorize) and
[ruby-graphviz](https://github.com/glejeune/Ruby-Graphviz) libraries
which were GPL and not compatible with the Gush MIT license. Replaced
them with [paint](https://github.com/janlelis/paint) and [graphviz](https://github.com/ioquatix/graphviz),
respectively.

Enhanced options for graph vizualization by allowing a filename to be
specified to retain the output of the graph. Allowed graphs to be
generated from specific workflows that exist in Redis in addition to
coming straight from the class definition (for systems that may choose
to make the structure of the graph dynamic based on inputs).

Standardized CLI [documentation
format](https://developers.google.com/style/code-syntax).
Removed GPL libraries in favor of MIT compatible ones
@rmorlok
Copy link
Contributor Author

rmorlok commented Jul 30, 2020

I believe the specs are fixed in this PR, though looking at the travis error, it may require a binary dependency dot that is missing. The specs would work locally for me (though I needed to make a minor tweak to set Redis.exists_returns_integer = true to deal with the change in Redis#status that was failing all specs for me).

@pokonski
Copy link
Contributor

Thanks! I'll merge this and adjust :)

@pokonski pokonski merged commit 779c6e0 into chaps-io:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants