Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not create_activity on an update action unless model is changed #290

Merged
merged 1 commit into from Mar 22, 2017
Merged

Do not create_activity on an update action unless model is changed #290

merged 1 commit into from Mar 22, 2017

Conversation

imsaar
Copy link

@imsaar imsaar commented Mar 17, 2017

No description provided.

@terry90
Copy link
Contributor

terry90 commented Mar 22, 2017

Merge?

@pokonski
Copy link
Member

Good change, thanks @imsaar 👍

@pokonski pokonski merged commit f29d965 into public-activity:1-5-stable Mar 22, 2017
@terry90
Copy link
Contributor

terry90 commented Mar 22, 2017

Thanks !

@terry90
Copy link
Contributor

terry90 commented Mar 22, 2017 •
edited

I have a warning, on Rails 5.1 RC1
Rails 5.1 deprecates changed?

DEPRECATION WARNING: The behavior of `changed?` inside of after callbacks will be changing in the next version of Rails.
The new return value will reflect the behavior of calling the method after `save` returned (e.g. the opposite of what it returns now).
To maintain the current behavior, use `saved_changes?` instead.
(called from activity_on_update at /Users/Doc/.rvm/gems/ruby-2.3.3/bundler/gems/public_activity-f29d96595d52/lib/public_activity/actions/update.rb:14

Should I open a new issue ?

terry90 added a commit to terry90/public_activity that referenced this pull request Mar 22, 2017
@terry90
Rails 5.1 compatibility for update action (for PR public-activity#290)
9e009b6
@terry90 terry90 mentioned this pull request Mar 22, 2017
Merged
terry90 added a commit to terry90/public_activity that referenced this pull request Mar 23, 2017
@terry90
Rails 5.1 compatibility for update action (for PR public-activity#290)
d3a151a
terry90 added a commit to terry90/public_activity that referenced this pull request Mar 23, 2017
@terry90
Rails 5.1 compatibility for update action (for PR public-activity#290)
e9db9a3
terry90 added a commit to terry90/public_activity that referenced this pull request Mar 23, 2017
@terry90
Rails 5.1 compatibility for update action (for PR public-activity#290)
54f357a
terry90 added a commit to terry90/public_activity that referenced this pull request Mar 23, 2017
@terry90
Rails 5.1 compatibility for update action (for PR public-activity#290)
fec8dbd
terry90 added a commit to terry90/public_activity that referenced this pull request Mar 29, 2017
@terry90
Rails 5.1 compatibility for update action (for PR public-activity#290)
05c34d4
terry90 added a commit to terry90/public_activity that referenced this pull request Mar 29, 2017
@terry90
Rails 5.1 compatibility for update action (for PR public-activity#290)
8b225d4
pokonski added a commit that referenced this pull request Mar 29, 2017
@pokonski
Merge pull request #291 from terry90/1-5-stable
16a4199 
Rails 5.1 compatibility for update action (for PR #290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terry90 terry90 terry90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@imsaar @terry90 @pokonski