Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Revise sample code for inline images #306

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Docs: Revise sample code for inline images #306

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4e608b
Revise imports to reflect working setup
twfahey1 Sep 27, 2022
029c991
Merge branch 'main' into links-docs-fix
twfahey1 Sep 27, 2022
6216a8d
Merge branch 'main' into links-docs-fix
twfahey1 Oct 15, 2022
a4a14b5
Merge branch 'main' into links-docs-fix
shadcn Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions www/content/guides/links.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ yarn add html-react-parser
Update the component from [images](/docs/guides/inline-images) to handle inline links.

```tsx title=components/body.tsx
import { HTMLReactParserOptions, domToReact } from "html-react-parser" // highlight-line
import { Element } from "domhandler/lib/node"
import { HTMLReactParserOptions, domToReact, Element } from "html-react-parser" // highlight-line
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't look right.

I took a look at the domhandler NPM package and it now exports Element from its main entry point. See Line 14 of src/index.ts.

So the change should be:

import { Element } from "domhandler"

import parse from "html-react-parser"
import Image from "next/image"
import Link from "next/link" // highlight-line
Expand Down