Feature/settings url length #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall this pull request is acceptable, if you fix the issues I highlighted. Thanks |
|
Thanks for the review. I will look into it. |
|
Modifying the use of local brevis settings in models and migrations. |
|
Thanks, I'll have a look at it during weekend. |
|
Alas, here we go. |
|
Hello @char0n Thanks! |
|
It looks good. I'll give it a go during the weekend. Thanks |
|
Merged to master. Thanks. |
|
Released 2.0.0 on pypi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request just uses a new settings to customize the length of the original url.
Url to be shortened might be containing a long list of query parameters.
Thus, a long url passes the URL validator.
Added tests test_model_save_too_long_original_url