Drop index on original_url and prevent a possible AttributeError exception #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By adding the original_url_hash field to the get_or_create call the index on original_url_hash is used instead. Grace to this, less storage space is used and the db operations are faster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the original_url field is longer than its hash, then it is more effective to drop the index on original_url and use the index on original_url_hash. Less storage space is used and the queries are processed faster.
In my case the average length of the original URLs is 140 characters. I suppose that there are many cases when the original URLs are shorter then 64 characters and the index on original_url offers better performance than the index on original_url_hash. I think however that the index on original_url_hash offers a good middle ground.