Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add ramda placeholder and make tests consistent #1328

Merged
merged 2 commits into from Feb 28, 2020
Merged

test: add ramda placeholder and make tests consistent #1328

merged 2 commits into from Feb 28, 2020

Conversation

js636f
Copy link
Collaborator

@js636f js636f commented Feb 28, 2020

Batch 21

Files:

test/

  • padCharsStart.js
  • padEnd.js
  • padStart.js
  • pathNotEq.js
  • pathOrLazy.js
  • paths.js
  • pickIndexes.js
  • propNotEq.js
  • reduceIndexed.js

char0n
char0n requested changes Feb 28, 2020
View reviewed changes
Copy link
Owner

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! We're already at r letter. Less than 20% togo ;] Please look at my review comments.

test/pathNotEq.js Show resolved Hide resolved
test/paths.js Outdated Show resolved Hide resolved
test/paths.js Outdated Show resolved Hide resolved
test/paths.js Show resolved Hide resolved
test/propNotEq.js Outdated Show resolved Hide resolved
test/reduceIndexed.js Outdated Show resolved Hide resolved
test/reduceIndexed.js Show resolved Hide resolved
char0n
char0n approved these changes Feb 28, 2020
View reviewed changes
Copy link
Owner

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@js636f
Copy link
Collaborator Author

js636f commented Feb 28, 2020

Thank you! CircleCI failed again, I'll keep restarting it until all tests will be green.

@js636f js636f merged commit 191e4da into char0n:master Feb 28, 2020
@js636f js636f deleted the MakeTestConsistentB21 branch March 5, 2020 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@js636f @char0n