Improved Hypothesis tests #167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And remove an expensive test that has never passed.
|
Closing as inactive, just to get it off my queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request builds on #165 by @hugovk. In addition to installing Hypothesis so they can be run in CI, this PR also:
(i.e. on the no-longer-supported Python 2.6)
xfailtest that has never passed. This was testing that for any string that does not have a detectable encoding, there is some suffix which when appended will allow an encoding to be detected.UTF8Proberwill never enter an error state on utf-8 encoded text. This failed on my machine, so it might help @blueyed debug Using unicode purple heart should not cause detection to lose confidence about utf-8 #128?