Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 4.x support #57

Merged
merged 3 commits into from Apr 25, 2023
Merged

Django 4.x support #57

merged 3 commits into from Apr 25, 2023

Conversation

filipweidemann
Copy link
Contributor

This PR adds test coverage for Django 4.x & Python 3.10 to the tox environment to ensure proper function when using those versions.

All checks should be green in CI, therefore I also bumped the supported versions in setup.py.

It would be really cool if you could merge this and release a new version @charettes.
Really loving this simple library :)

@charettes
Copy link
Owner

Thanks for the PR @filipweidemann appreciated. Do you think you could drop support for Python 3.6, any Django version < 3.2, and test against Python 3.11 as well.

Here's a commit that did just that charettes/django-seal@837d289.

Happy to push a new release once tests are passing.

@filipweidemann
Copy link
Contributor Author

Sure, I also bumped the release action to Python 3.7 if that's okay.
I saw you did the same thing over at django-seal so I figured it would probably be okay.

Could you please run the tests once more? Thank you! :)

@coveralls
Copy link

Coverage Status

Coverage: 99.112%. Remained the same when pulling 4337484 on Lfd4:master into 20c74a0 on charettes:master.

@charettes
Copy link
Owner

Thanks, @filipweidemann. I'll release a new version shortly.

@charettes charettes merged commit 0d27317 into charettes:master Apr 25, 2023
8 checks passed
@charettes
Copy link
Owner

@filipweidemann
Copy link
Contributor Author

@charettes wow that was fast!
Django 4.2 update path is unblocked now, tomorrow will be fun I guess!

Thank you for your time & we'll surely open PRs for 5.2 as well (when it drops) 🙂

@charettes
Copy link
Owner

np, thank you for submitting the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants