Skip to content

Commit

Permalink
Fix #76 -- Ensure SealableModel(seal) respects MRO.
Browse files Browse the repository at this point in the history
  • Loading branch information
charettes committed Sep 21, 2023
1 parent cda624a commit 037a025
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 2 additions & 0 deletions seal/models.py
Expand Up @@ -61,6 +61,8 @@ class SealableModel(models.Model):
"""

def __init_subclass__(cls, seal=None, **kwargs):
if seal is None:
seal = getattr(cls, "_seal_managers", seal)
cls._seal_managers = seal
return super().__init_subclass__(**kwargs)

Expand Down
11 changes: 9 additions & 2 deletions tests/test_models.py
Expand Up @@ -196,10 +196,17 @@ class SealedManagers(SealableModel):
)

class MixinInitSubclass:
def __init_subclass__(cls, foo, **kwargs):
def __init_subclass__(cls, foo=None, **kwargs):
cls.foo = foo
super().__init_subclass__(**kwargs)

class SealedModel(SealableModel, MixinInitSubclass, foo="bar", seal=True):
class SealedBaseModel(MixinInitSubclass, SealableModel, foo="bar", seal=True):
class Meta:
abstract = True

self.assertEqual(SealedBaseModel.foo, "bar")

class SealedModel(SealedBaseModel):
manager = SealableManager(seal=False)
as_manager = SealableQuerySet.as_manager(seal=False)

Expand Down

0 comments on commit 037a025

Please sign in to comment.