Avoid __class__ swap in pre-added field generation.

While clever it makes it harder to reason about the intended effect.
charettes · Nov 5, 2023 · 93fcbb6 · 93fcbb6
1 parent a36026a
commit 93fcbb6
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/syzygy/autodetector.py b/syzygy/autodetector.py
@@ -163,9 +163,18 @@ def add_operation(self, app_label, operation, dependencies=None, beginning=False
         super().add_operation(app_label, operation, dependencies, beginning)
 
     def _generate_added_field(self, app_label, model_name, field_name):
+        # Delegate most of the logic to super() ...
         super()._generate_added_field(app_label, model_name, field_name)
-        add_field = self.generated_operations[app_label][-1]
-        add_field.__class__ = AddField
+        # ... and immediately swap the added operation by an adjsuted one.
+        old_add_field = self.generated_operations[app_label][-1]
+        add_field = AddField(
+            old_add_field.model_name,
+            old_add_field.name,
+            old_add_field.field,
+            old_add_field.preserve_default,
+        )
+        add_field._auto_deps = old_add_field._auto_deps
+        self.generated_operations[app_label][-1] = add_field
         stage = OperationStage()
         self.add_operation(
             self.STAGE_SPLIT,