-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs need clarification (or code needs changing?) #68
Comments
You should indeed use the API endpoint in order to get things to work. So you say that if you set |
I can definitely add an example to the doc to hint at the fact that one must use |
Thanks! If I set my host to |
I updated the readme and the docs and will merge the change soon after the tests pass. |
Maybe it's just my setup at work with github enterprise.
I set my
github-review-host
to"git.mycompany.com"
but I needed to useapi.git.mycompany.com
in order to get things to work.Otherwise, it bombed out with an unhelpful
Got an error from the GitHub API (wrong-type-argument stringp nil)!
even though it never sent the request asghub--auth
was erroring out.Actually, maybe there's a bug somewhere. Because when I call
gitreview-submit-commet
it usesgit.mycompany.com
as the host.The text was updated successfully, but these errors were encountered: