Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs need clarification (or code needs changing?) #68

Closed
slackorama opened this issue Dec 23, 2020 · 4 comments
Closed

docs need clarification (or code needs changing?) #68

slackorama opened this issue Dec 23, 2020 · 4 comments

Comments

@slackorama
Copy link

slackorama commented Dec 23, 2020

Maybe it's just my setup at work with github enterprise.

I set my github-review-host to "git.mycompany.com" but I needed to use api.git.mycompany.com in order to get things to work.

Otherwise, it bombed out with an unhelpful Got an error from the GitHub API (wrong-type-argument stringp nil)! even though it never sent the request as ghub--auth was erroring out.

Actually, maybe there's a bug somewhere. Because when I call gitreview-submit-commet it uses git.mycompany.com as the host.

@charignon
Copy link
Owner

You should indeed use the API endpoint in order to get things to work. So you say that if you set github-review-host to api.git.mycompany.com it makes the request against git.mycompany.com?

@charignon
Copy link
Owner

I can definitely add an example to the doc to hint at the fact that one must use api.git.mycompany.com and not git.mycompany.com but before I want to check that it works well for you (it works for me).

@slackorama
Copy link
Author

Thanks!

If I set my host to api.git.mycompany.com doing a review/comment from a forge request works without a hitch.

charignon added a commit that referenced this issue Jan 25, 2021
charignon added a commit that referenced this issue Jan 25, 2021
@charignon
Copy link
Owner

I updated the readme and the docs and will merge the change soon after the tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants