-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the squeezing problem of the Selector div #65
Conversation
I changed the display from `flex `to `-webkit-inline-box`, cause it solves the squeezing problem, if you not gonna merge it them let me pass styles to it through prop
Thanks for the PR! I'll take a look at it this weekend. |
Not sure why the build is failing, but I can look into that as well. |
maybe it's with the bot |
If you need it urgently, I would recommend using your forked branch for now. |
how to do that ? |
I'd recommend doing a google search. I cannot be your web-dev teacher. Thanks for understanding. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is failing because there are duplicate display
keys in the counterStyle object. There are better ways to apply vendor-specific prefixes. The inline-box
value is also outdated.
If you can make changes to fix the PR, I would be happy to reevaluate it. |
Closing due to inactivity. |
I changed the display from
flex
to-webkit-inline-box
, cause it solves the squeezing problem, if you not gonna merge it then let me pass styles to it through prop