Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the squeezing problem of the Selector div #65

Closed
wants to merge 1 commit into from
Closed

Fixing the squeezing problem of the Selector div #65

wants to merge 1 commit into from

Conversation

the-wrong-guy
Copy link

@the-wrong-guy the-wrong-guy commented Mar 17, 2021 •
edited
Loading

I changed the display from flex to -webkit-inline-box, cause it solves the squeezing problem, if you not gonna merge it then let me pass styles to it through prop

@the-wrong-guy
Fixing the squeezing problem of the Selector div
75ef5c1 
I changed the display from `flex `to `-webkit-inline-box`, cause it solves the squeezing problem, if you not gonna merge it them let me pass styles to it through prop
@charkour
Copy link
Owner

Thanks for the PR! I'll take a look at it this weekend.

@charkour charkour self-assigned this Mar 17, 2021
@charkour
Copy link
Owner

Not sure why the build is failing, but I can look into that as well.

@the-wrong-guy
Copy link
Author

the-wrong-guy commented Mar 17, 2021 •
edited
Loading

Not sure why the build is failing, but I can look into that as well.

maybe it's with the bot
And can you please do it by today itself i need it urgently, just change the display to -webkit-inline-box

@charkour
Copy link
Owner

If you need it urgently, I would recommend using your forked branch for now.

@the-wrong-guy
Copy link
Author

If you need it urgently, I would recommend using your forked branch for now.

how to do that ?

@charkour
Copy link
Owner

charkour commented Mar 17, 2021 •
edited
Loading

I'd recommend doing a google search. I cannot be your web-dev teacher. Thanks for understanding.

charkour
charkour requested changes Mar 22, 2021
View reviewed changes
Copy link
Owner

@charkour charkour left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is failing because there are duplicate display keys in the counterStyle object. There are better ways to apply vendor-specific prefixes. The inline-box value is also outdated.

@charkour charkour linked an issue Mar 22, 2021 that may be closed by this pull request
Trouble styling some counters #64
Closed
@charkour
Copy link
Owner

If you can make changes to fix the PR, I would be happy to reevaluate it.

@charkour
Copy link
Owner

charkour commented Oct 3, 2021

Closing due to inactivity.

@charkour charkour closed this Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charkour charkour charkour requested changes

Assignees

@charkour charkour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trouble styling some counters
2 participants
@the-wrong-guy @charkour