Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change where storeCreator is passed #26

Closed
wants to merge 1 commit into from
Closed

change where storeCreator is passed #26

wants to merge 1 commit into from

Conversation

charkour
Copy link
Owner

@charkour charkour commented Apr 6, 2024

Shaves 4 bytes. Is this better?

Copy link

github-actions bot commented Apr 6, 2024

Coverage Report for ./tests

Status Category Percentage Covered / Total
🔵 Lines 100% 52 / 52
🔵 Statements 100% 52 / 52
🔵 Functions 100% 3 / 3
🔵 Branches 100% 5 / 5
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/index.ts 100% 100% 100% 100%
Generated in workflow #2

@charkour
Copy link
Owner Author

charkour commented Jun 1, 2024

We shouldn't do this because it changes where we pass the createStore to higher up, so it's less helpful to generate a store without props.

@charkour charkour closed this Jun 1, 2024
@charkour charkour deleted the alt-api branch June 2, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant