Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/code cleanup #28

Merged
merged 4 commits into from
Apr 17, 2020
Merged

Bugfix/code cleanup #28

merged 4 commits into from
Apr 17, 2020

Conversation

VR-Nic
Copy link
Contributor

@VR-Nic VR-Nic commented Apr 17, 2020

This branch cleans up some code from VRTK. 3 things were done:

  1. Removed all VRTK obsolete code
  2. Converted all of VRTK's EventArgs that were structs into classes that inherit from EventArgs
  3. Removed all _UnityEvent classes

@VR-Nic VR-Nic requested a review from ddugganCRA April 17, 2020 15:25
ddugganCRA
ddugganCRA approved these changes Apr 17, 2020
View reviewed changes
Copy link
Collaborator

@ddugganCRA ddugganCRA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Nic. Thanks for taking care of this boring but essential cleanup.

@VR-Nic VR-Nic merged commit b5f7eb6 into release/v1.0.3 Apr 17, 2020
@VR-Nic VR-Nic deleted the bugfix/code_cleanup branch April 17, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddugganCRA ddugganCRA ddugganCRA approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@VR-Nic @ddugganCRA