Feature/event bus reactions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome! @VR-Nic please move the EventBus sample scene to Virtuoso/Scenes, it is currently at the root of the repo. Otherwise great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds the Event bus system for Interactable Objects. With the Event Bus Hierarchy, GameObjects can be given a hierarchical ID (i.e. InteractableObject/Gun/Pistol) and reactions can be tied to the hierarchy of the ID. For example, you can set reactions for the grab event on any GameObject that has the hierarchy InteractableObject/Gun.
Additionally, removed the error about no reactions in the scene since it was not helpful, Resolves #27.
Removed the IReaction interface since in practice, all reactions need to be MonoBehaviors and implement the GenericReaction class anyways.