Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/event bus reactions #29

Merged
merged 3 commits into from
Dec 22, 2020
Merged

Conversation

VR-Nic
Copy link
Contributor

@VR-Nic VR-Nic commented Dec 16, 2020

This branch adds the Event bus system for Interactable Objects. With the Event Bus Hierarchy, GameObjects can be given a hierarchical ID (i.e. InteractableObject/Gun/Pistol) and reactions can be tied to the hierarchy of the ID. For example, you can set reactions for the grab event on any GameObject that has the hierarchy InteractableObject/Gun.

Additionally, removed the error about no reactions in the scene since it was not helpful, Resolves #27.

Removed the IReaction interface since in practice, all reactions need to be MonoBehaviors and implement the GenericReaction class anyways.

@VR-Nic VR-Nic added the enhancement New feature or request label Dec 16, 2020
@VR-Nic VR-Nic changed the base branch from master to release/v1.0.3 December 16, 2020 15:46
@ddugganCRA
Copy link
Collaborator

Looks awesome! @VR-Nic please move the EventBus sample scene to Virtuoso/Scenes, it is currently at the root of the repo. Otherwise great.

@VR-Nic VR-Nic merged commit d6f8dcd into release/v1.0.3 Dec 22, 2020
@VR-Nic VR-Nic deleted the feature/event_bus_reactions branch December 22, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reactor Inspector doesn't work in prefab view
2 participants