Furtive patach syllables with sof pasuq incorrect isClosed

[charlesLoder]

The problem
When a syllable with a furtive patach also has a sof pasuq \u{5C3}, the isClosed property is to true the opposite of what it normally is.

Some consideration
A syllable with a furtive patach is actually closed.

The current way of doing things is semantically incorrect but consistent.

Options

1. Fix it so that a furtive patach syllable with a sof pasuq has isClosed set to false

2. Update the syllabifier so that furtive patach syllables:

• have the text actually be correct (i.e. patach + chet , not like the current chat + patach)
• set the isClosed property correctly

[charlesLoder]

See this issue

[charlesLoder]

Closing this as not planned.

The issue that sparked this was that a furtive patach followed by a sof pasuq (or potentially a colon if that is what was used), e.g. "רֽוּחַ׃" would not transliterate correctly.

• Expected: rûaḥ
• Received: rûḥa

The original thought was that furtive patach syllables should be closed, enabling the reverse of these lines — i.e. could check for syl.isClosed instead of !syl.isClosed.

The idea to switch how a furtive patach is encoded is a bad idea.

The furtive patach is currently encoded as "chet/ayin/he + patach"/

The idea was to encode it as "patach + chet/ayin/he".

This is a bad idea b/c no font knows how to render that encoding correctly.