-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
double marks #61
Comments
Just noting that I see this. Had a baby a few months ago, and time on this project has slowed |
No rush. The library is very useful as it is. Have a great time! |
Found some free time! I assume these are your own tests? I'll try to take them one-by-one
The You would have to write an
It's counting the geresh and the revia as stressed syllables. What text is that from? That may be a bug, or my limited understanding of taamim (almost certainly the latter).
Interesting, if you copy & paste from a text like Mishneh Torah, the sof pasuq after רוּחַ is actually a colon, but in Psalms 18:11 it's an actual sof pasuq. This is definitely a bug 🐞
Another bug! 🐞
I like this idea, but not totally sure I follow the first example.
With the default settings, I get: console.log(heb.transliterate(`שַׁוְעִ֗י`));
// šawʿî The
Yeah, the I'm not too sure how to check a word like this other than just a regex, which would be pretty similar to an I'll have to mull over it. If you have any ideas, drop them here. |
Closes this. New issues have been created |
Not sure of settings but the following fail if inserted in the tests. Text from Sefaria.
produces double dagesh mark instead:
produces double stress mark instead:
produces "ha" instead of "ah":
does not separate maqaf:
By the way is it possible to have SILENT_SHEVA and MAPPIQ settings (default to blank strings)? For example "שַׁוְעִ֗י" can become "shavi" if silent sheva is not marked, instead of "shav,i". And "הִ֛וא" occurs often enough that it would be great to have a setting for it instead of the cpu-consuming ADDITIONAL_FEATURES; right now it translates to "hiv'" instead of just "hi". Thank you for this project!
The text was updated successfully, but these errors were encountered: