Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on Windows #1

Closed
charlesangus opened this issue Dec 10, 2018 · 10 comments
Closed

Build on Windows #1

charlesangus opened this issue Dec 10, 2018 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@charlesangus
Copy link
Owner

Plugins have only been built/tested on Centos Linux.

dbr added a commit to dbr/DeepC that referenced this issue Jan 7, 2019
Builds successfully on macOS 10.13, untested but should work on Linux and possibly even even Windows (issues charlesangus#1 and charlesangus#2)
dbr added a commit to dbr/DeepC that referenced this issue Jan 9, 2019
Builds successfully on macOS 10.13, untested but should work on Linux and possibly even even Windows (issues charlesangus#1 and charlesangus#2)
@charlesangus charlesangus added the help wanted Extra attention is needed label Apr 24, 2019
@jonassorgenfrei
Copy link
Collaborator

Hey @charlesangus,
i would like to help out with the Windows Site for DeepC.
I will take a look and create a PR when i got it working.

@charlesangus
Copy link
Owner Author

Awesome, thanks! Looking forward to it.

@charlesangus
Copy link
Owner Author

I can't remember all the issues I've run into trying to get this to work, and it's been a while since I've tried, so sorry for the vagueness:

  • there's a variable, I think one of the enums, that shadows some built-in variable on Windows and needs to be changed (easy enough to fix)
  • I seem to recall there's something in the way the classes are structured or something that's not supported on Windows, which is a bit of a sticky wicket

Stay in touch and post any error messages you get stuck on and I'll see if I can remember anything more.

@jonassorgenfrei
Copy link
Collaborator

Don't worry i will just find my way trough the compiler errors :) and adjust them accordingly.

I see thanks for the heads up :)
Yeah saw some array initializiation too which doesnt compile on windows like
float myArray[amount]

Will go trough it this weekend to make it code wise working and in the beginning of next week i will get a nuke dev licence to test it out in nuke then :)

@jonassorgenfrei
Copy link
Collaborator

Got it working (the compiling step). Will test next week when i am able to run it in nuke :)

@jonassorgenfrei
Copy link
Collaborator

Okay finally got my nuke licence and was able to test it.
It compiles and loads in nuke but i get access violations when running any DeepCWrapper at
DeepCWrapper.cpp line 356
return dynamic_cast<Iop*>(op)

@charlesangus can you tell me what the test_input function is supposed to do?

@jonassorgenfrei
Copy link
Collaborator

jonassorgenfrei commented Dec 3, 2021

Okay seems like it is something with my settings. The examples crash too. Will investigate more into it.

EDIT: Got the examples working now; will try to use them as reference to find out whats going wrong. Have a little bit the feeling the compiler/nuke doesn't like the wrapper module 🤔

@charlesangus
Copy link
Owner Author

charlesangus commented Dec 3, 2021 via email

@jonassorgenfrei
Copy link
Collaborator

jonassorgenfrei commented Dec 5, 2021

Works on windows now:
https://github.com/jonassorgenfrei/DeepC

Could anyone with a linux machine give it a try to make sure i didn;t break anything there?
@charlesangus @falkhofmann

The main problem was line 360ff:
default_input(int input)
With the missing initializer for the dummy cast:
Black* dummy = new Black(); return dynamic_cast<Op*>(dummy);

Is there any reason why the Black Dummy cast was used instead of a return 0?
Since currently when using dynamic_cast<Op*>(dummy);
The node defaults on site_maks rgba.alpha and i need to disable it for seeing any result.
When using return 0 on the second input it works fine as expected.

@falkhofmann
Copy link
Collaborator

falkhofmann commented Dec 5, 2021

hey jonas,
i gave your fork a spin, build and loaded them.
seems to work fine. at least i dont see an issue inside nuke.

nevertheless I do agree on the side mask default. would better to have it turned of on default/creation.

but when i am building from my fork the defaults are correct.
so this might be something to take care of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants