Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more type hints to make mypy lint more #2

Merged
merged 1 commit into from
Aug 27, 2023
Merged

Add more type hints to make mypy lint more #2

merged 1 commit into from
Aug 27, 2023

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Aug 25, 2023

I've just learned about python/mypy#4409 and in general, mypy doesn't type check a function if it has no annotations, so you need to often include an explicit return type to do so.

I also forgot that dict and list are type-checked starting from Python 3.9, so I removed the use of Dict and List.

@charlesetc charlesetc merged commit e171e5a into charlesetc:main Aug 27, 2023
@charlesetc
Copy link
Owner

Sounds great, thank you!

@kevinji kevinji deleted the more-type-hints branch August 27, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants