-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for different flow styles in Sequences #40
Conversation
Hey @knightzmc, thanks for the PR. It looks like the formatting check is failing - could you please run |
In fact, it looks like your IDE might have reformatted the test file - could you please revert the unrelated changes so that it's clear what you've changed? |
Oh, that's weird. When I ran the tests it told me that spotless had failed so I formatted it. Must've accidentally changed something |
@charleskorn I ran spotless again, it seemed to have fixed all of the formatting issues. |
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
============================================
+ Coverage 88.65% 88.73% +0.07%
- Complexity 124 125 +1
============================================
Files 9 9
Lines 564 568 +4
Branches 120 120
============================================
+ Hits 500 504 +4
Misses 36 36
Partials 28 28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for this PR. It looks good to me - there are only two minor things and then I think this should be good to merge.
Hi @charleskorn I've gone through the diff and reverted all of the accidental test changes, along with adding a simple doc |
Looks great, thanks again for the PR @knightzmc! |
This adds support for the Flow Style of rendering Sequences, by adding a parameter to
YamlConfiguration
The default block style is still used to avoid breaking anything.
This is referenced in #33