Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for different flow styles in Sequences #40

Merged
merged 4 commits into from
Sep 3, 2020
Merged

Add support for different flow styles in Sequences #40

merged 4 commits into from
Sep 3, 2020

Conversation

bristermitten
Copy link
Contributor

This adds support for the Flow Style of rendering Sequences, by adding a parameter to YamlConfiguration

The default block style is still used to avoid breaking anything.

This is referenced in #33

@charleskorn
Copy link
Owner

Hey @knightzmc, thanks for the PR. It looks like the formatting check is failing - could you please run ./gradlew spotlessApply to fix any issues and push that change?

@charleskorn
Copy link
Owner

In fact, it looks like your IDE might have reformatted the test file - could you please revert the unrelated changes so that it's clear what you've changed?

@bristermitten
Copy link
Contributor Author

Oh, that's weird. When I ran the tests it told me that spotless had failed so I formatted it. Must've accidentally changed something

@bristermitten
Copy link
Contributor Author

@charleskorn I ran spotless again, it seemed to have fixed all of the formatting issues.

@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2020

Codecov Report

Merging #40 into master will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #40      +/-   ##
============================================
+ Coverage     88.65%   88.73%   +0.07%     
- Complexity      124      125       +1     
============================================
  Files             9        9              
  Lines           564      568       +4     
  Branches        120      120              
============================================
+ Hits            500      504       +4     
  Misses           36       36              
  Partials         28       28              
Impacted Files Coverage Δ Complexity Δ
...n/kotlin/com/charleskorn/kaml/YamlConfiguration.kt 100.00% <100.00%> (ø) 8.00 <2.00> (+1.00)
src/main/kotlin/com/charleskorn/kaml/YamlOutput.kt 94.73% <100.00%> (ø) 36.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fbd643...d2d6626. Read the comment docs.

Copy link
Owner

@charleskorn charleskorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this PR. It looks good to me - there are only two minor things and then I think this should be good to merge.

@bristermitten
Copy link
Contributor Author

Hi @charleskorn I've gone through the diff and reverted all of the accidental test changes, along with adding a simple doc

@charleskorn
Copy link
Owner

Looks great, thanks again for the PR @knightzmc!

@charleskorn charleskorn merged commit a4464df into charleskorn:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants