Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHA256 verification to download scripts #41

Merged
merged 1 commit into from Jul 8, 2019
Merged

Add SHA256 verification to download scripts #41

merged 1 commit into from Jul 8, 2019

Conversation

ddz
Copy link
Contributor

@ddz ddz commented Jul 8, 2019

Verify downloaded archives against expected SHA256 checksums in cmake.sha256sum and ninja.sha256sum.

@charlesnicholson
Copy link
Owner

You seem trustworthy, approved!

@charlesnicholson
Copy link
Owner

It looks like circle isn't kicking off the build. I have no idea what's going on but found this:

https://support.circleci.com/hc/en-us/articles/360008097173-Why-aren-t-pull-requests-triggering-jobs-on-my-organization-

Would you mind trying to "star" / "watch" this repo and then push a dummy change to see if that kicks off circle? If not, I'll adopt it and apply it under my account but give you credit...

@charlesnicholson
Copy link
Owner

Ah nevermind, I found the circleci setting to build on forked PR's. It probably needs a nudge from you, though, maybe you could add an empty commit?

Otherwise there was another form, just send me your SSN, DOB, and credit card and that should work.

@charlesnicholson
Copy link
Owner

This looks better:
Screen Shot 2019-07-08 at 7 43 00 AM

@ddz
Copy link
Contributor Author

ddz commented Jul 8, 2019

I added a small commit to kick off the CI build. All of my PII is en route under separate cover (because security).

@charlesnicholson charlesnicholson merged commit 93479dc into charlesnicholson:master Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants