Magsafe led control #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Great job! Thank you. I will test it on a MBP14 later. Introduction to this feature will be added to README in a separate commit, with acknowledgements. BTW, can you fix the CI so I can merge? There are some linter issues. |
|
I will fix it in a few days, now in research about blocking sleep to charge with closed lid (more priority for me) |
charlie0129
approved these changes
Jun 20, 2023
|
I fixed the linter errors. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not well tested, but for me works (MBP 14 2023, M2 Max)
Led on magsafe magnetic connector Green/Orange depending on charging enabled or not.