Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove genius dependency #188

Closed
JosiahParry opened this issue Dec 2, 2022 · 5 comments · Fixed by #189
Closed

Remove genius dependency #188

JosiahParry opened this issue Dec 2, 2022 · 5 comments · Fixed by #189

Comments

@JosiahParry
Copy link
Collaborator

heya! I'm not longer maintaining the genius library and want to archive it on CRAN. The package hasn't worked appropriately for quite some time. Can we remove the genius dependency so I can archive the package without taking down spotifyr?

@charlie86
Copy link
Owner

@JosiahParry hey! Hope all is well. No worries - feel free to go ahead and archive, and I'll monitor and update.

@RaymondBalise
Copy link

I just tried devtools::install_github('charlie86/spotifyr') and I got this message:

ERROR: dependency ‘genius’ is not available for package ‘spotifyr’

Is there a way to install spotifyr?

@JosiahParry
Copy link
Collaborator Author

This is my fault. I'll work on a PR to fix at the moment. Install genius first, (even though it doesn't work).

devtools::install_github("josiahparry/genius")
devtools::install_github("charlie86/spotifyr")

@antaldaniel
Copy link
Collaborator

Hi Josiah,

I am now maintaining the CRAN process, and there are a few small changes that should go into the next full CRAN release, as there are a few other pull requests that need to be incorporated.

Unless @charlie86 wants to do it, I gladly remove the genius dependency. Also, if you want to keep genius as a package on CRAN but lack time to maintain it, I can take over the maintainer role there, too.

Even in this case, removing the genius as a dependency is safer than writing a vignette on how the two packages can work in harmony.

Best regards,
Daniel

@JosiahParry
Copy link
Collaborator Author

@antaldaniel PR is made. The only change I think that is worth double checking is get_album_data() since this is no longer returning lyrics it may cause backward compatible breaking changes. The rest is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants