Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filter album dupes more aggresively #34

Closed
charlie86 opened this issue Jun 25, 2018 · 3 comments
Closed

filter album dupes more aggresively #34

charlie86 opened this issue Jun 25, 2018 · 3 comments

Comments

@charlie86
Copy link
Owner

No description provided.

@charlie86
Copy link
Owner Author

get_artist_albums() tries to filter out duplicate albums by stripping out extra added on text from album names (e.g. "live edition", "remastered"), but some dupes still slip through. Look at Miles Davis for some examples

@shermstats
Copy link

Example:

Miles Davis scored a French movie called Ascenseur pour l'échafaud. Spotify has "Ascenseur pour l'échafaud", "Ascenseur pour l'echafaud" (no accent), and "Ascenceur pour l'échafaud" (switches the s for a c).

@charlie86
Copy link
Owner Author

@shermstats After thinking more about it, I'm going to leave this up to the end user. Since there's no way of knowing what people would like to return, it's safer to return everything spotify has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants