Add readonly attribute to DateInput when it isn't typeable #547
Conversation
|
It's very useful for us and we wait this feature! |
| @@ -239,7 +239,7 @@ describe('Datepicker.vue set by timestamp', () => { | |||
| wrapper = shallow(Datepicker, { | |||
| propsData: { | |||
| format: 'yyyy MM dd', | |||
| value: new Date(2018, 0, 29).getTime() | |||
| value: new Date(Date.UTC(2018, 0, 29, 0, 0, 0)).getTime() | |||
There was a problem hiding this comment.
The 0, 0, 0 part is redundant
If hours is supplied, let h be ToNumber(hours); else let h be 0.
If minutes is supplied, let min be ToNumber(minutes); else let min be 0.
If seconds is supplied, let s be ToNumber(seconds); else let s be 0.
If ms is supplied, let milli be ToNumber(ms); else let milli be 0.
Hopefully this gets merged soon
|
And this readonly attribute should be enough to safely delete these lines: |
|
@saintplay I didn't even realise there was already an issue open for #497. I'm on holiday at the moment so I will add your feedback into the pull request when I get back. |
|
and check out #505 as well |
|
Came here looking for this. Great PR! Any idea on when this gets released? :-) |
|
@saintplay made the changes, could you please give it another review? What is the next step towards getting it merged into the main repository? |
|
Looks good to me. @charliekassel |
src/components/PickerMonth.vue
Outdated
| this.disabledDates.from && | ||
| (this.utils.getMonth(date) > this.utils.getMonth(this.disabledDates.from) && this.utils.getFullYear(date) >= this.utils.getFullYear(this.disabledDates.from)) || | ||
| (this.disabledDates.from && | ||
| this.utils.getMonth(date) > this.utils.getMonth(this.disabledDates.from) && |
There was a problem hiding this comment.
What is this change of behaviour for?
In any case I don't think we need that this.disabledDates.from as it's handled in the line before.
There was a problem hiding this comment.
The linter was complaining about mixing the && and || operators like that. I'm pretty sure this doesn't change any functionality?
There was a problem hiding this comment.
I've removed the extra check but now conflicts with your branch, can you pull and fix at your end please?
|
@charliekassel I merged in the fix |
|
@charliekassel any idea when this will be up on npm? I'm working on something that uses this and really need to prevent the keyboard from popping up asap |
|
@nickhall in the mean time do the following to get it working for your project:
|
|
Kind of waiting for this to get published on NPM :-) |
|
Waiting for this. Mobile keyboard pop up stinks :) |
|
@riksnelders version 1.5.3 was published to NPM 3 days ago. I haven't tested it myself yet, but the new version should include this pull request. |
Adding this attribute removes the caret from the text input and improves the behaviour when the datepicker is used on your phone. The caret is still there for Firefox but it works for Chrome and Safari. On phones the readonly attribute stops the keyboard from appearing, which is annoying if the date picker isn't typeable.
I also fixed a test that breaks when run in the eastern hemisphere and fixed some issues the linter identified.