Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add showCalendarOnFocus prop #611

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jesusantguerrero
Copy link

@jesusantguerrero jesusantguerrero commented Oct 12, 2018

This PR add the functionality to open the calendar on focus, I didn't touched the current functionality but prevented to emit twice the event showCalendar when this prop is true.

This will allow to use datepicker with tab
and it solves #454

@coveralls
Copy link

coveralls commented Oct 12, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling f08a7e3 on jesusantguerrero:feature-showCalendarOnFocus into 7056546 on charliekassel:master.

@zgreen
Copy link

zgreen commented Feb 14, 2019

Anything I can do to help here? Would be great to get this merged.

@losclipp
Copy link

losclipp commented May 6, 2019

Hm... If I set showCalendarOnFocus as true and click on the datepicker it will be opened. And if I click once again it wouldn't be closed.

if showCalendarOnFocus is true and click on the datepicker it will be opened. And if I click once again it should be closed.
…rero/vuejs-datepicker into feature-showCalendarOnFocus
@jesusantguerrero
Copy link
Author

@losclipp I updated the PR to handle that behavior. thanks for let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants