Custom parsing for dates

[tnolli]

This is a possible fix for #597

[coveralls]

Coverage remained the same at 100.0% when pulling 1cb2670 on tnolli:features/typed-dates-custom-parsing into 7cc1c32 on charliekassel:master.

[sylann]

Great solution!

I've searched for javascript string parsing solutions that could work with a format string, but it can become tricky.

I think this solution should be merged quite rapidly since users who aren't using US dates, currently face a major bug with the typeable datepicker feature.
Allowing developers to use their own parser, should cover most of the cases, especially when predictable date formats are used.

👍

[sylann]

I suggest your replace line 122-123 with this:

const parsed = this.parse(this.input.value)

[sylann]

I suggest your replace line 126 with this:

this.$emit('typedDate', parsed)

[sylann]

I suggest your replace line 135-136 with this:

if (this.typeable && isNaN(this.parse(this.input.value))) {

[sylann]

I suggest you replace line 122 with this:

parse: {
  type: Function,
  default: v => new Date(v),
}

[tnolli]

@SylannBin thanks for the code review; I applied your suggestions (almost entirelly, Ijust moved the default to DateInput instead of Datepicker),

[zzen]

OK I just spent an hour debugging this, only to arrive at the same solution (we need a custom parsing function). Any chances this can get merged (or reasons not to)?

[lechinoix]

Hello ! Also facing this problem using this lib, is it possible to merge ?

[aesfer]

This feature not only solves a bunch of potential parsing issues but it also enables new use cases out of the box, such as:

• Triggering validation errors (which occur during the parse function).
• Contextual date parsing. For instance in a fromDate - toDate range, I would like 1980 to be parsed as 1980/01/01 in fromDate and parsed as 1908/12/31 in toDate.

Hopefully this gets merged soon.

[ConorSheehan1]

First of all, thanks @charliekassel for all your work on this. It's awesome!

I think this pr could close a huge amount of issues. Just for example:

• Typing the date doesn't follow set format #486
• "typeable" ignores "format" #583
• Using properties language and typeable together #597
• Custom format and typeable true #616
• Using : typeable="true" not expected behavior #636
• When using the format "dd-MM-yyyy", the date disappears from the input field by event of the blur. #677
• Typing in a date with yyyy-MM-dd format selects wrong day #678
• its cleared on blur if using properties "typeable" and "langague" together  #733
• input clears on blur (Firefox) #767

The equivalent pr for delegating formatting dates was merged the same day it was opened!
#232 This has been open for 9 months now, and the last comment was 6 months ago.

Also, I would choose this over #536 because it lets users choose how the date is parsed, rather than changing the string that get's passed to Date.parse.

I just read #679 (comment) and saw you haven't had time to work on this, and are considering co-maintainers, which I think is a great idea!
Just wondering, is there any chance of this being merged soon?

[otaviogaiao]

Any news on this?

[roeb]

When is this feature merged? It is urgently needed for different projects.

[LeonidasJP]

Any updates on when/whether this PR will be merged? It blocks development in several projects at the moment, so an update would be very nice ;-)
Does @tnolli have to rebase his branch first, before this can be merged?

[soulaimanassikiou]

Here! also waiting for the merge!!!

[fabio-fafle]

Any news?

[heivo]

Is there anything that we can do to help this getting merged?