Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of typed input with use-utc=true #747

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ij1
Copy link

@ij1 ij1 commented Jul 12, 2019

Date.parse assumes non-UTC dates by default, which results in incorrect date calculation with use-utc=true. As Date.parse itself has no UTC variant, fix this problem by appending " UTC" into the end of the date to designate the timezone of the parsed date string.

This fixed at least #666 and may also fix some other issues.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 453a27f on ij1:typeable-utc-fix into de0fc75 on charliekassel:master.

@tuan-bui
Copy link

Thanks for the fix!

This fix updates initial date throwing incorrect date when not passing in an initial date with use-utc=true.

Would we be able to get this merged in the next update @charliekassel ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants