Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typing information and opened event #809

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Typing information and opened event #809

wants to merge 6 commits into from

Conversation

gmoneh
Copy link

@gmoneh gmoneh commented Mar 10, 2020

This pull request adds two features to the component:

  • Typing information for use in typescript environments
  • The documentation makes reference to an "opened" event that is fired when the calendar element is opened. However, the component did not actually fire that event ever. So the emit for the event was added in the appropriate place, and now the behavior of the code matches the documentation.

@gmoneh
Vuejs-datepicker type information
d2e75e3
@gmoneh
Fixed unit test to look for UTC date (as in the input).
a9ec0c7
@gmoneh
- Emit "opened" event when calendar is opened.
57e3f9a 
- Emit "closed" event when calendar closes by input losing focus.
@gmoneh
Include types file in distribution.
2e20dc6 
(cherry picked from commit 2b446b849d00babd9ca0af0262f727b704942567)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 2e20dc6 on gmoneh:master into de0fc75 on charliekassel:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gmoneh @coveralls